Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bidengine): parse GPU interface #234

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(bidengine): parse GPU interface #234

merged 1 commit into from
Apr 25, 2024

Conversation

andy108369
Copy link
Contributor

  • Update parseGPU function to handle 'interface' attribute for GPUs

fixes akash-network/support#216

Tested on the Hurricane provider with NVIDIA T4

SDL with interface only

  • interface is present now! ✔️

image

D[2024-04-24|17:18:36.459] reservation requested. order=akash1z6ql9vzhsumpvumj4zs8juv7l5u2zyr5yax2ys/16019495/1/1, resources=[{"resource":{"id":1,"cpu":{"units":{"val":"1000"}},"memory":{"size":{"val":"4294967296"}},"storage":[{"name":"default","size":{"val":"10737418240"}}],"gpu":{"units":{"val":"1"},"attributes":[{"key":"vendor/nvidia/model/t4/interface/pcie","value":"true"}]},"endpoints":[{"kind":1,"sequence_number":0},{"sequence_number":0}]},"count":1,"price":{"denom":"uakt","amount":"1000000.000000000000000000"}}] module=provider-cluster cmp=provider cmp=service cmp=inventory-service

SDL with ram only

  • ram is present as before ✔️

image

D[2024-04-24|17:18:06.496] reservation requested. order=akash1z6ql9vzhsumpvumj4zs8juv7l5u2zyr5yax2ys/16019488/1/1, resources=[{"resource":{"id":1,"cpu":{"units":{"val":"1000"}},"memory":{"size":{"val":"4294967296"}},"storage":[{"name":"default","size":{"val":"10737418240"}}],"gpu":{"units":{"val":"1"},"attributes":[{"key":"vendor/nvidia/model/t4/ram/16Gi","value":"true"}]},"endpoints":[{"kind":1,"sequence_number":0},{"sequence_number":0}]},"count":1,"price":{"denom":"uakt","amount":"1000000.000000000000000000"}}] module=provider-cluster cmp=provider cmp=service cmp=inventory-service

SDL with both ram & interface

image

D[2024-04-24|17:32:30.358] reservation requested. order=akash1z6ql9vzhsumpvumj4zs8juv7l5u2zyr5yax2ys/16019634/1/1, resources=[{"resource":{"id":1,"cpu":{"units":{"val":"1000"}},"memory":{"size":{"val":"4294967296"}},"storage":[{"name":"default","size":{"val":"10737418240"}}],"gpu":{"units":{"val":"1"},"attributes":[{"key":"vendor/nvidia/model/t4/ram/16Gi/interface/pcie","value":"true"}]},"endpoints":[{"kind":1,"sequence_number":0},{"sequence_number":0}]},"count":1,"price":{"denom":"uakt","amount":"1000000.000000000000000000"}}] module=provider-cluster cmp=provider cmp=service cmp=inventory-service

@andy108369 andy108369 requested review from boz and troian as code owners April 24, 2024 17:34
@andy108369 andy108369 mentioned this pull request Apr 24, 2024
Closed
troian
troian requested changes Apr 25, 2024
View reviewed changes
bidengine/shellscript.go Outdated Show resolved Hide resolved
@andy108369
fix(bidengine): parse GPU interface
137cd12 
- Update parseGPU function to handle 'interface' attribute for GPUs

fixes akash-network/support#216
@andy108369 andy108369 force-pushed the bidengine-pass-gpu-interface branch from cf8e86d to 137cd12 Compare April 25, 2024 15:45
@troian troian merged commit d9527c8 into akash-network:main Apr 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troian troian troian approved these changes

@boz boz Awaiting requested review from boz boz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

akash-provider doesn't pass the GPU interface to the bid price script
2 participants
@andy108369 @troian